Skip to content

Conversation

kim
Copy link
Contributor

@kim kim commented Oct 5, 2025

Historically, controldb reads could be treated as just a datastructure,
but that became a lie when reconnections were introduced.

Some tricks were employed to enter the async context when needed, but
those always bear the risk of introducing a deadlock somewhere.

So, just make it async.

Expected complexity level and risk

2

It may or may not be safe to use sled in an async context. We did already for
the write path, but if it's a problem it'll show now.

Testing

Not a functional change.

Historically, controldb reads could be treated as just a datastructure,
but that became a lie when reconnections were introduced.

Some tricks were employed to enter the async context when needed, but
those always bear the risk of introducing a deadlock somewhere.

So, just make it async.
@bfops bfops added release-any To be landed in any release window and removed release-1.6-nice-to-have labels Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants